Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: disable tpcds-q41 due to not support decorrelate disjunction subquery #5369

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

jackwener
Copy link
Member

Which issue does this PR close?

related #5368 .

Rationale for this change

What changes are included in this PR?

disable tpcds-q41

Are these changes tested?

N/A

Are there any user-facing changes?

N/A

@github-actions github-actions bot added the core Core DataFusion crate label Feb 23, 2023
@jackwener jackwener requested a review from alamb February 23, 2023 04:54
@@ -320,6 +320,7 @@ async fn tpcds_logical_q57() -> Result<()> {
}

#[tokio::test]
#[ignore] // decorrelate disjunction decorrelate subquery isn't supported.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the issue that when we turn on "skip failed optimizer rules" this query errors?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend putting a link to #5368 in the comment as well so this is easier to find / reneable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend putting a link to #5368 in the comment as well so this is easier to find / reneable

Great idea.

@ursabot
Copy link

ursabot commented Feb 24, 2023

Benchmark runs are scheduled for baseline = 095f934 and contender = 1309267. 1309267 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

jiangzhx pushed a commit to jiangzhx/arrow-datafusion that referenced this pull request Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants